Bug with "Can not ban is Server Admin"

[JFF-Vince]

Thanks NeHo,

We ran into this also... thinking maybe the check should include if steam > 0...

Any thoughts on if this will be a fix, or if we simply should not have admins without steam id ?

thanks

Vince

[NeHo]

Not sure what you mean, if somebody applies for admin rights via the application he must have steam linked, otherwise he can not apply as server admin.

The only way I could solve it, is to remove all admin rights from users who unlink steam from their profile page

[JFF-Vince]

I find this in app/controllers/rconcmd/index.js

and we are looking to match on the steam_id, but seems maybe check that steam_id > 0 first ?

I too removed the admin permissions from some who did not properly have set.

Thanks

User.findOne({'steam.id':checkplayerdata.player_steam_id, 'local.user_role': {$gt: 100}}, function( err, checkifimune ) {
if (checkifimune){
req.flash('error_messages', req.t('rcon_commands:general.is_imune', { get_AdminName: checkifimune.local.user_name }));
res.redirect('back');

[NeHo]

That's a good idea I will look at, just fixed another bug where I use cod4x plugin http to update players ingame visual settings, it was broken.

After I finish it I will look at this part, maybe i will also check there if there is an admin with no steam linked and remove him and send him a notification that he is removed because he had no steam account linked.

[ravindu2500]

Admins should link the steam account to the web admin tool? to work ban?

[NeHo]

Yes, not only for ban, steam is the admin authentication, no steam = no rights

[ravindu2500]

how to set up steam with panel? any post about it?

[NeHo]

@ravindu2500 Go to plugin SSO Steam Settings via admin panel, when you visit that page there is a tutorial, when you finish everything activate the plugin

[ravindu2500]

@NeHo
Set your "returnURL" as the domain you access your app with /user/auth/steam/return, appended to it (e.g. https://www.mygreatwebsite.com/user/auth/steam/return)

i don't understand this sorry

[NeHo]

@ravindu2500 said in Bug with "Can not ban is Server Admin":

https://www.mygreatwebsite.com

replace this part "https://www.mygreatwebsite.com" with your website or IP, make sure to use http if you dont have ssl (I added an example with https, if needed put there http)

[ravindu2500]

@NeHo I did but still not working
},
"steamAuth" : {
"returnURL" : "http://snd.deathkinggaming.com/user/auth/steam/return",
"realm" : "http://snd.deathkinggaming.com",
"apiKey" : "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"
},

should i change the path for specific my own path?

[NeHo]

http://snd.deathkinggaming.com:3000

"steamAuth" : {
"returnURL" : "http://snd.deathkinggaming.com:3000/user/auth/steam/return",
"realm" : "http://snd.deathkinggaming.com:3000",
"apiKey" : "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"

You forgott the port

[ravindu2500]

@NeHo still getting that error

"steamAuth" : {
	"returnURL"         : "http://snd.deathkinggaming.com:3000/user/auth/steam/return",
	"realm"     : "http://snd.deathkinggaming.com:3000",
	"apiKey"      : "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"
},

[NeHo]

wait 5-10 minutes on steam, they need some time

[ravindu2500]

@NeHo should I add the port when I add the domain name in the steam website?

[ravindu2500]

@NeHo
No error changes to "admin"

[NeHo]

@ravindu2500 Read post begining

[ravindu2500]

it works thanks alot

[NeHo]

This issue will be solved in the next v4.0.0 update

[SMiLeY]

@neho said in Bug with "Can not ban is Server Admin":

This issue will be solved in the next v4.0.0 update

Still happening